Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link insertion / editing enhancements #19

Closed
b-kelly opened this issue Mar 15, 2021 · 1 comment · Fixed by #142
Closed

Link insertion / editing enhancements #19

b-kelly opened this issue Mar 15, 2021 · 1 comment · Fixed by #142
Labels
enhancement New feature or request mode - markdown Affects the editor's markdown input mode mode - rich text Affects the editor's rich text (wysiwyg) mode
Milestone

Comments

@b-kelly
Copy link
Collaborator

b-kelly commented Mar 15, 2021

Reported on Meta.SE. Related report here.

Is your feature request related to a problem? Please describe.

Link editing and insertion is currently confusing. The button only highlights when text has already been selected and you cannot insert a link without pre-selecting text.

I’m not sure all users will understand how the ‘Link selection’ button works. (Hint: you have to select the text first, then the button will become enabled.)

Describe the solution you'd like

Other rich text editors I use regularly have an 'Insert Link' button where you can specify both the link and the text to display.
So something like this (excuse the bad mockup, hopefully the idea is clear):

Or enable the button at all times, and if nothing is selected, ask the user for a link (like the current editor) and insert it, with the popover visible so that users know they can edit both the link text and the link itself:

@b-kelly b-kelly added the enhancement New feature or request label Mar 15, 2021
@aaronshekey
Copy link
Contributor

Yeah, I'd like to see us move away from popovers here. They seem to be getting in the way of text selection and the like.

@b-kelly b-kelly added mode - markdown Affects the editor's markdown input mode mode - rich text Affects the editor's rich text (wysiwyg) mode labels Oct 7, 2021
@b-kelly b-kelly added this to the Beta 1 milestone Apr 20, 2022
b-kelly added a commit that referenced this issue Jun 3, 2022
@b-kelly b-kelly mentioned this issue Jun 17, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mode - markdown Affects the editor's markdown input mode mode - rich text Affects the editor's rich text (wysiwyg) mode
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants