Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toggle heading only when same level #125

Merged
merged 4 commits into from
May 12, 2022

Conversation

dancormier
Copy link
Contributor

@dancormier dancormier commented May 11, 2022

Fixes #105

Another simple fix that hopefully is not too naïve. Also added a few tests that hopefully give us good heading-related coverage. Once this PR merges, I'd like to add the remaining tests outlined as it.todos.

TODO

  • Add tests

@dancormier dancormier added bug Something isn't working mode - rich text Affects the editor's rich text (wysiwyg) mode labels May 11, 2022
@netlify
Copy link

netlify bot commented May 11, 2022

Deploy Preview for nifty-lalande-39c157 ready!

Name Link
🔨 Latest commit 06e2ff2
🔍 Latest deploy log https://app.netlify.com/sites/nifty-lalande-39c157/deploys/627d6aceb05fb8000b9c6930
😎 Deploy Preview https://deploy-preview-125--nifty-lalande-39c157.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dancormier dancormier requested a review from b-kelly May 11, 2022 20:34
@double-beep
Copy link
Contributor

Also fixed in #110

@dancormier
Copy link
Contributor Author

@b-kelly seems like linting isn't working as expected on my machine. I'll look into it.

Copy link
Collaborator

@b-kelly b-kelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for the unit tests as well. I made a few tweaks to the wording and whitespace, but this otherwise looks good.

@dancormier dancormier merged commit 7b5b5c1 into main May 12, 2022
@dancormier dancormier deleted the dcormier/heading-select-105 branch May 12, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mode - rich text Affects the editor's rich text (wysiwyg) mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heading selection UX improvements
3 participants