fix(notice): improve contrast of inline code #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancormier
changed the title
dancormier
changed the title
|
I had previously figured out the color combos needed for the comment box — so these should work for the blue notice. To do the other colors, we'll some design time and that's not going to happen until the end of this quarter (we have bug bash I can assign this to someone). You can also verify if the the other colors work with the same color stops but I bet there will be issues with red and yellow. 
|
…1678) * refactor(notice): generate styles programmatically; improve contrast * Update notice tests to include `code`, `a.s-link.s-link__inherit` children * Fix comment typo Addresses https://github.com/StackExchange/Stacks/pull/1678/files#r1525084777
|
Merging this since the changes here are really just from #1678 which has been reviewed and approved. 🚢 |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
s-noticecomponent currently has insufficient color contrast when used in combination with inlinecodeelements. Here's what it looks like in dark mode, for example:I'm opening this PR to give us a playground to discuss and fix this problem. I tried to play around with various color combinations for the background and text colors myself but quickly realized that I've got no idea what we're aiming for from a visual perspective. I could tweak the colors until I hit the right color contrast, obviously, but I really need some guidance on the visual design, too.