Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(focus): apply per-component focus styles on focus classes #1680

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

dancormier
Copy link
Contributor

This PR applies custom focus styles set on specific components to their relevant atomic focus class. This ensures that when an atomic focus class is added to one of these components (or their children when applicable), they gain the correct styles.

Example (Muted button)

Not the .focus-inset-bordered on the markup below. It should render the button as if it is focused. In the "before" example, you'll see that the button did not receive the background color and font color you'd expect to see with this class added and when this button is focused.

<button class="s-btn s-btn__dropdown s-btn__icon s-btn__muted focus-inset-bordered" role="presentation">
    <svg ></svg>
    Button
<button>

Before

image

After

image

@dancormier dancormier added bug A reproducible problem with the Stacks code accessibility labels Mar 15, 2024
Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit a040172
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/65f49b143123f000070398b0
😎 Deploy Preview https://deploy-preview-1680--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dancormier dancormier merged commit 7a9a864 into develop Mar 15, 2024
11 checks passed
@dancormier dancormier deleted the dcormier/custom-focus-styles-on-focus-classes branch March 15, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug A reproducible problem with the Stacks code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant