Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extension method to simplify using SqlBuilder.Templates with Query method #269

Closed
wants to merge 2 commits into from

Conversation

Obalix
Copy link
Contributor

@Obalix Obalix commented Apr 15, 2015

Added the static DapperSqlBuilderMixin class inside the SqlBuilder project to provide SqlSpecific extensions to Dapper.

The first extension method implemented here is a method simplifying the use of SqlBuilder.Template with the Query method. So instead of writing

cnn.Query(template.RawSql, template.Parameters, ...);

the user can write

cnn.Query(template, ...);

@NickCraver
Copy link
Member

We'd like to pull this in, but can you please add a unit test for the actual execution? This also illustrates the usage to someone finding it. In addition, for public methods we really need XML comments so someone using intellisense can see how to use this method. It's a good addition, and one I'd use personally - just needs a bit more love :)

@NickCraver
Copy link
Member

Closing due to inactivity and inability to merge - ping to reopen if anything changes!

@NickCraver NickCraver closed this Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants