Use cloudflare-go

[tresni]

Previously this was using a homemade implementation of the Cloudflare API. I really wanted to implement registrar support for Cloudflare, but I didn't want to have to write all the necessary structs by hand. This also means we should automatically gain benefits of any improvements in the cloudflare-go library.

Integration tests look good, but go-staticcheck says that pageRuleConstraint is unused which is a dirty lie. Soon I should have another PR adding support for Cloudflare as a registrar.

[tresni]

Turns out that activating the proxy is not covered by the test suite. When I actually try to run this with a domain using proxied records I get:

#2: ACTIVATE PROXY for new record @ CNAME 1 $TARGET.
FAILURE! cannot modify record if domain or record id are empty

Looking into this now

[tresni]

@tlimoncelli I don't know why this isn't doing integration tests for Cloudflare as I have the necessary secrets on my side. tresni#6 should show the results here soon as I couldn't think of a better way to prove that it worked.

[tlimoncelli]

Holy cow! This is quite a PR!

“One of my most productive days was throwing away 1,000 lines of code.”
— Ken Thompson, co-inventor of Unix and C

Ever since the official cloudflare-go module was released I'd been thinking about incorporating it in dnscontrol. Thanks for working through all the changes. This is going to make cloudflare a lot more reliable.

creds: As far as why aren't the integration tests working: Github takes the secrets from the owner's repo. I see that's what it is doing in tresni#6. I also ran the tests from my system and everything is fine.

go-staticcheck: I wouldn't worry about it. Maybe move the struct's definition to be above its first use?

Tom

CC @captncraig because his excellent, clean, code made this rewrite so easy. Look at how often our home-grown structs and funcs were basically the same as what the official module had.

[tresni]

@tlimoncelli let me know if there’s anything else you’d like to see.