Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEXONET: Support long TXT records and fix whitespace bug #1283

Merged
merged 6 commits into from
Oct 4, 2021

Conversation

tlimoncelli
Copy link
Contributor

@tlimoncelli tlimoncelli commented Oct 4, 2021

The implementation of TXT records for Hexonet had some bugs

  • Trailing whitespace wasn't supported. This was due to a bug. The new code supports whitespace at the front, middle, and end.
  • TXT records with multiple sub-strings wasn't supported. The code now supports this
  • Long TXT records were rejected. The code now splits them properly.

This builds on #1276 by @buraktamturk, who figured out the key issue. To quote @Papakai , "many thanks for contributing - lack of time on my end, very appreciated! Let me forward my deepest gratitude for caring."

CC @Papakai @buraktamturk

@tlimoncelli tlimoncelli merged commit 7f071b4 into master Oct 4, 2021
@tlimoncelli tlimoncelli deleted the buraktamturk-hexonetTxtFix branch October 4, 2021 16:09
@tlimoncelli tlimoncelli mentioned this pull request Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants