Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AZURE_DNS: GetZones error should report subscription id #1415

Merged
merged 5 commits into from Feb 22, 2022
Merged

AZURE_DNS: GetZones error should report subscription id #1415

merged 5 commits into from Feb 22, 2022

Conversation

tlimoncelli
Copy link
Contributor

Make it easier to debug creds issue by reporting the subscription id.

@tlimoncelli
Copy link
Contributor Author

The new error message looks like this: ("REDACTED" is where the subscription ID appears)

getZones: zonesErr: SubscriptionID="REDACTED" err=dns.ZonesClient#ListByResourceGroup: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="AuthorizationFailed" Message="The client 'REDACTED' with object id 'REDACTED' does not have authorization to perform action 'Microsoft.Network/dnsZones/read' over scope '/subscriptions/REDACTED/resourceGroups/global/providers/Microsoft.Network' or the scope is invalid. If access was recently granted, please refresh your credentials."

griogar
griogar approved these changes Feb 18, 2022
View reviewed changes
Copy link

@griogar griogar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

griogar
griogar approved these changes Feb 22, 2022
View reviewed changes
Copy link

@griogar griogar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlimoncelli tlimoncelli merged commit 8b74b7c into master Feb 22, 2022
@tlimoncelli tlimoncelli deleted the tlim_azureerr branch February 22, 2022 18:35
tlimoncelli added a commit that referenced this pull request Mar 26, 2022
@tlimoncelli
AZURE_DNS: GetZones error should report subscription id (#1415)
7c81176 
* BIND: Bug: DefaultNS strips last char

* fixup!

* Report Subscription ID when Azure can't get zones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@griogar griogar griogar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tlimoncelli @griogar