Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRANSIP: Implementation get-zones all #1980

Merged
merged 2 commits into from Jan 23, 2023

Conversation

cafferata
Copy link
Collaborator

@cafferata cafferata commented Jan 23, 2023

dnscontrol get-zones transip - all
$ORIGIN cafferata.dev.
$TTL 86400
@                IN MX    10 ASPMX.l.google.com.
                 IN MX    20 alt1.ASPMX.l.google.com.
                 IN MX    30 alt2.ASPMX.l.google.com.
                 IN MX    40 ASPMX2.googlemail.com.
                 IN MX    50 ASPMX3.googlemail.com.
                 IN MX    60 ASPMX4.googlemail.com.
                 IN MX    70 ASPMX5.googlemail.com.
                 IN TXT   "v=spf1 -all"

cc: @blackshadev

@cafferata cafferata changed the title TransIP: Implementation of TransIP get-zones all. TransIP: Implementation get-zones all Jan 23, 2023
@blackshadev
Copy link
Contributor

lgtm, nice work! I didn't know about this GetZones interface.

I see the branch is out of date, could you rebase on master?

@cafferata cafferata changed the title TransIP: Implementation get-zones all TRANSIP: Implementation get-zones all Jan 23, 2023
@blackshadev
Copy link
Contributor

I think @tlimoncelli wants you to rebase instead of creating a merge commit. But I will leave that up to @tlimoncelli to decide since he is the maintainer.

@cafferata
Copy link
Collaborator Author

cafferata commented Jan 23, 2023

Thought I'd give the 'update branch' feature within GitHub (mobile) a try. 🤷‍♂️ I also prefer a 'rebase', fixed anyway. 👌

@tlimoncelli
Copy link
Contributor

I'm in the rebase camp but I'm not offended by the use of merge :-) . (Personally I have a git alias p = pull --rebase --ff-only --prune)

(and, yes, by completing the ZoneLister interface, the feature magically appears. Go is pretty cool)

Tom

@tlimoncelli tlimoncelli merged commit b9b35d5 into StackExchange:master Jan 23, 2023
@cafferata cafferata deleted the transip-get-zones-all branch January 24, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants