Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: Fixed LOC_BUILDER_STR filename #2199

Merged
merged 2 commits into from Mar 20, 2023
Merged

DOCS: Fixed LOC_BUILDER_STR filename #2199

merged 2 commits into from Mar 20, 2023

Conversation

cafferata
Copy link
Collaborator

@cafferata cafferata commented Mar 17, 2023 •
edited

This pull request fixed the broken LOC_BUILDER_STR({}) link on LOC. #2188 #2183 cc: @systemcrash

@systemcrash
Copy link
Contributor

This and #2198 may get superseded by #2197 if #2197 gets merged. Basically all docs get restructured. Then these would apply better.

I think I missed a few things in the docs adding LOC 😅

@cafferata
Copy link
Collaborator Author

Thanks @systemcrash for the link. 👍 I've been reading the GitHub pull request from old to new and got to #2197 😅

@tlimoncelli
Copy link
Contributor

I'm fine with waiting until #2197.

@cafferata
Copy link
Collaborator Author

Personally I would merge since the current link doesn't work.

@systemcrash
Copy link
Contributor

systemcrash commented Mar 17, 2023 via email

@tlimoncelli tlimoncelli merged commit 1bf6a4c into StackExchange:master Mar 20, 2023
@cafferata cafferata deleted the docs/loc-record-type branch March 20, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cafferata @systemcrash @tlimoncelli