Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW FEATURE: M365_BUILDER() (Microsoft 365 builder) #2365

Merged
merged 5 commits into from May 17, 2023

Conversation

juliusrickert
Copy link
Contributor

@juliusrickert juliusrickert commented May 16, 2023

Closes #1023.

Caveats/Open questions

  • I'm not an expert (far from it) regarding Microsoft 365
  • Setting TTLs isn't possible
  • Which features should be enabled by default?
  • Docs could certainly be improved

@tlimoncelli
Copy link
Contributor

Looks good to me! I don't use M365 so I can't test it but it seems fine!

  • I'm not an expert (far from it) regarding Microsoft 365

Me too!

  • Setting TTLs isn't possible

I'm ok with that!

  • Which features should be enabled by default?

My general rule is to have the defaults be the recommended practice. A lazy person that just goes with the defaults should get a reasonable system.

  • Docs could certainly be improved

I think you've documented the important parts. Docs can evolve over time. It might be useful to link to a Microsoft document that explains the meaning of all the settings.

Tom

P.S. Please run the code through prettier (instructions at the top of helpers.js)?

@juliusrickert
Copy link
Contributor Author

  • Setting TTLs isn't possible

I'm ok with that!

My thinking was that some records (like MX records) usually have a longer TTL.
But setting them with DefaultTTL (which would influence all records) should be fine for now.

  • Which features should be enabled by default?

My general rule is to have the defaults be the recommended practice. A lazy person that just goes with the defaults should get a reasonable system.

For most people, enabling the Skype for Business and MDM records should not influence other services running on the domain, so we could enable them by default.
I just didn't do it because I wasn't using them at the time of writing the helper.

  • Docs could certainly be improved

I think you've documented the important parts. Docs can evolve over time. It might be useful to link to a Microsoft document that explains the meaning of all the settings.

Alright :)

P.S. Please run the code through prettier (instructions at the top of helpers.js)?

Done so.

Should I squash the commits or will you do so?

@tlimoncelli
Copy link
Contributor

Looks good!

Github is configured to squash when it does a merge.

Anything else or shall I merge?

@juliusrickert
Copy link
Contributor Author

Anything else or shall I merge?

No, feel free to merge :)

@tlimoncelli
Copy link
Contributor

Thanks for the cool new macro!

@tlimoncelli tlimoncelli changed the title Add Microsoft 365 builder NEW FEATURE: Microsoft 365 builder May 17, 2023
@tlimoncelli tlimoncelli changed the title NEW FEATURE: Microsoft 365 builder NEW FEATURE: M365_BUILDER() (Microsoft 365 builder) May 17, 2023
@tlimoncelli tlimoncelli merged commit 08cdba4 into StackExchange:master May 17, 2023
5 checks passed
@cafferata
Copy link
Collaborator

Sorry for party crashing! documentation/functions/record/M365_BUILDER.md needs to be added to SUMMARY. Fixed by #2371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helper for Microsoft 365
3 participants