New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW FEATURE: M365_BUILDER() (Microsoft 365 builder) #2365
Conversation
Looks good to me! I don't use M365 so I can't test it but it seems fine!
Me too!
I'm ok with that!
My general rule is to have the defaults be the recommended practice. A lazy person that just goes with the defaults should get a reasonable system.
I think you've documented the important parts. Docs can evolve over time. It might be useful to link to a Microsoft document that explains the meaning of all the settings. Tom P.S. Please run the code through prettier (instructions at the top of helpers.js)? |
My thinking was that some records (like
For most people, enabling the Skype for Business and MDM records should not influence other services running on the domain, so we could enable them by default.
Alright :)
Done so. Should I squash the commits or will you do so? |
Looks good! Github is configured to squash when it does a merge. Anything else or shall I merge? |
No, feel free to merge :) |
Thanks for the cool new macro! |
Sorry for party crashing! |
Closes #1023.
Caveats/Open questions