Strip ANSI color codes from notifications #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not very long ago, ansi color support was enabled in dnscontrol, to ease reviewing of changesets. This doesn't play well with notifications, as they usually can't render these codes; slack for example outputs the escape codes, leading to ugly and hard to grasp messages. This changeset ensures that any message coming to a notifier will get stripped of ansi color codes, before passed on to the notifier. That way, notifiers are then free to re-add colors in a way that is supported in the relevant platform.
|
Looks good and works as I would expect. |
tlimoncelli
changed the title
tlimoncelli
reviewed
Aug 21, 2023
No need to compile this on every invocation. Thanks to @tlimoncelli for the suggestion!
|
should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not very long ago, ansi color support was enabled in dnscontrol, to ease reviewing of changesets.
This doesn't play well with notifications, as they usually can't render these codes; slack for example outputs the escape codes, leading to ugly and hard to grasp messages. See #2499 for a few examples.
This changeset ensures that any message coming to a notifier will get stripped of ansi color codes, before passed on to the notifier.
That way, notifiers are then free to re-add colors in a way that is supported in the relevant platform.