ROUTE53: Allow R53_ALIAS records to enable target health evaluation #2649
Conversation
|
CC @vatsalyagoel for visibility. Wow! Jonathan, I gotta say this is an impressive PR! Adding record meta modifiers is not well documented but it looks like you got it all right! Plus you've included documentation and tests! Thanks! I'll merge this before the next release unless @vatsalyagoel has any comments/corrections. |
|
Thanks @tlimoncelli ! Happy to help. I'm looking to use dnscontrol to manage some of my more complicated Route53 zones, but I think I'm going to need some additional features in the Route53 provider. Alias target health evaluation was just one of the first challenges I encountered. Eventually, I'd love to add support for some (or all) of the various routing policies supported by Route53: |
|
Oops! I meant to CC @tresni instead of @vatsalyagoel. (Copy-and-paste error!) |
Sounds good to me! Oh, I just noticed one thing I'd like to see added to this PR. Could you add integration tests to |
R53_ALIAS records have a property which allows them to evaluate target health. This was previously hardcoded to false for all R53_ALIAS records. This has been added as a new record modifier instead of a new parameter to R53_ALIAS to remain backwards compatible. The previous default behavior has been maintained. - Add R53_EVALUATE_TARGET_HEALTH record modifier to enable this behavior - Update provider to account for this setting during record conversion - Update RecordConfig receivers to allow this setting to be detected during diff - Update getZones command to include this setting in dumped config - Update unit tests - Update integration tests - Update documentation
jonathanbouvier
force-pushed
the
evaluate_target_health
branch
from
f0bca55
to
e28eee1
Compare
I just modified/added integration tests. |
|
Great! Thanks! |
tlimoncelli
changed the title
R53_ALIAS records have a property which allows them to evaluate target health. This was previously hardcoded to false for all R53_ALIAS records.
This has been added as a new record modifier instead of a new parameter to R53_ALIAS to remain backwards compatible. The previous default behavior has been maintained.