OVH: Allow ovh provider to connect to other endpoints than EU (#2625) #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge#2625) This introduces the `endpoint` provider configuration parameter. If not provided the provider will connect to the EU region for backward compatibility. The `endpoint` can be set to `eu`, `us` or `ca` depending on the OVH region the use wants to manage domains and zones in. It can also be set to any arbitrary URL for future OVH regions.
When all corrections are non modifying corrections (ie report only), we don't need to add the REFRESH ZONE correction. This was making some of the IGNORE integration test failed because the test system was checking for 0 corrections applied.
masterzen
force-pushed
the
masterzen/2625-ovh-endpoint-config
branch
from
fab1fad
to
19d8d6a
Compare
tlimoncelli
changed the title
|
Thanks! |
|
P.S. Thank you for a great PR. This is great! It fixes a real problem, has tests, and you updated the docs! I wish all PRs would be so complete! Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2625, allowing users to set OVH provider
endpointconfiguration to:eu(default) to target the EU API endpointcato target the Canada API endpointusto target the US API endpointIf omitted, the default is the EU endpoint for backward compatibility.