Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROUTE53: add R53_EVALUATE_TARGET_HEALTH to documentation summary #2659

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

jonathanbouvier
Copy link
Contributor

This new record modifier wasn't showing up in the documentation. Is there anywhere else that needs to be updated to get this working?

@tlimoncelli
Copy link
Contributor

That's odd! The table of contents (navigation) is manually generated, and this PR should fix that.

However I don't see the page that the TOC will link to. It looks like the rebuild process worked (https://github.com/StackExchange/dnscontrol/actions/runs/7035630609/job/19146466173). Let's see if merging this and re-pushing the pages forces it to work. Failing that, it could be an issue with build/generate/functionTypes.go.

Tom

@tlimoncelli tlimoncelli merged commit 74a9e5e into StackExchange:master Nov 29, 2023
2 checks passed
@jonathanbouvier
Copy link
Contributor Author

@tlimoncelli
Copy link
Contributor

Interesting!

I think the problem is that the system that translates /documentation/functions/record into /language-reference/record-modifiers isn't smart enough to handle relative links.

CC @cafferata

@cafferata
Copy link
Collaborator

See GitHub pull request #2669 for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants