Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD: Add stringer #2714

Merged
merged 4 commits into from
Dec 11, 2023
Merged

CICD: Add stringer #2714

merged 4 commits into from
Dec 11, 2023

Conversation

tlimoncelli
Copy link
Contributor

@tlimoncelli tlimoncelli commented Dec 11, 2023

This should fix the build problem.

CC @cafferata

@cafferata
Copy link
Collaborator

Looks good!

Questions:

  1. Why is the testcase TXT leading ws commented out?

  2. Is there another way to ensure the Go package stringer? The command go install golang.org/x/tools/cmd/stringer@latest is now on two places:

    1. go install golang.org/x/tools/cmd/stringer@latest
    2. .github/workflows/pr_test.yml
My locally reproducible case: "stringer": executable file not found
export GOPATH=""
go generate ./...
pkg/diff2/diff2.go:3: running "stringer": exec: "stringer": executable file not found in $PATH
pkg/txtutil/txtcode.go:1: running "stringer": exec: "stringer": executable file not found in $PATH
providers/capabilities.go:1: running "stringer": exec: "stringer": executable file not found in $PATH

@cafferata
Copy link
Collaborator

Perhaps change the GitHub pull request title to CICD: Add stringer so that it is properly included in the release changelog.

@tlimoncelli tlimoncelli changed the title Add stringer CICD: Add stringer Dec 11, 2023
@tlimoncelli
Copy link
Contributor Author

Questions:

  1. Why is the testcase TXT leading ws commented out?

It's more of a reminder to add that text in the future. A number of providers fail the test and would need to be fixed or have their auditrecords.go be updated.

  1. Is there another way to ensure the Go package stringer? The command go install golang.org/x/tools/cmd/stringer@latest is now on two places:

    1. go install golang.org/x/tools/cmd/stringer@latest
    2. .github/workflows/pr_test.yml

That was a typo. Its now in 1 place.

Tom

@tlimoncelli tlimoncelli merged commit 9e1cb0f into master Dec 11, 2023
15 checks passed
@tlimoncelli tlimoncelli deleted the tlim_stringer branch December 11, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants