Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: Fix golint warnings about stuttering #2718

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Conversation

tlimoncelli
Copy link
Contributor

CC @blackshadev

Fix these golint warnings:

pkg/dnsgraph/dnsgraph.go:15:6: type name will be used as dnsgraph.DNSGraphEdge by other packages, and that stutters; consider calling this Edge
pkg/dnsgraph/dnsgraph.go:22:6: type name will be used as dnsgraph.DNSGraphEdges by other packages, and that stutters; consider calling this Edges
pkg/dnsgraph/dnsgraph.go:25:6: type name will be used as dnsgraph.DNSGraphNode by other packages, and that stutters; consider calling this Node

I used VSCode's "rename symbol" which seems to take care of all the right things. However I'm splitting this out as its own PR in case we need to roll it back.

@tlimoncelli
Copy link
Contributor Author

@blackshadev I won't merge this until I hear from you. No rush.

@blackshadev
Copy link
Contributor

Go ahead and merge. It is a great suggestion, I love these kind of automated tools the whole reason for the duplicate naming was because it first didn't have it's own package. And when I moved it to it's own package I was busy making things work and then forgot.

@tlimoncelli
Copy link
Contributor Author

👍

@tlimoncelli tlimoncelli merged commit 2e4aa7a into master Dec 12, 2023
14 of 15 checks passed
@tlimoncelli tlimoncelli deleted the tlim_dnstutter branch December 12, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants