Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POWERDNS: Enables DHCID #2911

Merged
merged 1 commit into from
Apr 17, 2024
Merged

POWERDNS: Enables DHCID #2911

merged 1 commit into from
Apr 17, 2024

Conversation

fuero
Copy link
Contributor

@fuero fuero commented Apr 17, 2024

Simply enables DHCID records for PowerDNS, tested on 4.9.0 - works fine.

@tlimoncelli
Copy link
Contributor

Awesome!! Thanks for looking into this!

@tlimoncelli tlimoncelli merged commit 0cd3c2f into StackExchange:main Apr 17, 2024
2 checks passed
@tlimoncelli
Copy link
Contributor

sadly POWERDNS tests are failing now. See
https://github.com/StackExchange/dnscontrol/actions/runs/8739063541/job/24026058848

@fuero
Copy link
Contributor Author

fuero commented Apr 19, 2024

I replicated the test against my PowerDNS server:

#1: ± MODIFY test.xxx DHCID (ABEB593aKQECqDZ1CasNGlGcc1z9LsAhFigRvymaqGKgJNs= ttl=9600) -> (Test/AuCccgoJbsaxcQc9TUapptP69lOjxfNuVAA2kjEA= ttl=9600)
FAILURE! unexpected status code 422: https://pdns-int.xxx/api/v1/servers/localhost/zones/xxx Record test.fuehricht.name./DHCID 'Test/AuCccgoJbsaxcQc9TUapptP69lOjxfNuVAA2kjEA=': Not in expected format (parsed as 'Test/AuCccgoJbsaxcQc9TUapptP69lOjxfNuVAA2kjE')

So yes, the test fails, as the value given is not a valid base64 string:

base64 -d <<<"Test/AuCccgoJbsaxcQc9TUapptP69lOjxfNuVAA2kjEA="
M�-�
    �q�(%�����5���O��N�͹P�H�base64: invalid input

If I use a proper base64 value, it works:

base64 <<< "FOO"
Rk9PCg==

Push:

#1: ± MODIFY test.xxx DHCID ( ABEB593aKQECqDZ1CasNGlGcc1z9LsAhFigRvymaqGKgJNs= ttl=9600) -> (Rk9PCg== ttl=9600)

@tlimoncelli
Copy link
Contributor

Ah! Good detective work!

Please send a PR that fixes the test.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants