Fix #341 do not erase all records labels #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlimoncelli
reviewed
Mar 21, 2018
pkg/normalize/validate.go
Outdated
| @@ -321,7 +321,7 @@ func NormalizeAndValidateConfig(config *models.DNSConfig) (errs []error) { | |||
| } | |||
|
|
|||
| // Populate FQDN: | |||
| //rec.NameFQDN = dnsutil.AddOrigin(rec.GetLabel(), domain.Name) | |||
| rec.NameFQDN = dnsutil.AddOrigin(rec.GetLabel(), domain.Name) | |||
There was a problem hiding this comment.
Please use rec.SetLabel() as it will set both .Name and .NameFQDN at the same time.
This is to prevent all labels to get erased by the empty LabelFQDN during calls to `PunyCode`, until a better fix is found.
masterzen
force-pushed
the
bugfix/341-do-not-erase-all-records-labels
branch
from
0887a8e
to
db42e18
Compare
|
@tlimoncelli I've updated the PR so that it uses |
This was referenced Mar 22, 2018
rblenkinsopp
pushed a commit
to rblenkinsopp/dnscontrol
that referenced
this pull request
Aug 21, 2020
…nge#342) This is to prevent all labels to get erased by the empty LabelFQDN during calls to `PunyCode`, until a better fix is found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just puts back the code as it was before until a correct and better fix is found :)