Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments and updates, Adding basic unit testing #64

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Adjustments and updates, Adding basic unit testing #64

merged 1 commit into from
Sep 10, 2020

Conversation

namachieli
Copy link
Collaborator

Fixes

Additions

  • CODEOWNER file
  • Basic unit testing and structure for expanded unit testing

After updating ./bin/template.jinja, ./bin/generate_openapi.py was re-ran to remove required from the parameter token for all actions generated.

Reviews would be greatly appreciated!

@@ -13,7 +13,9 @@ parameters:
type: string
{%- for param in parameters %}
{{ param['name'] }}:
{%- if param['name'] != "token" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of having this override here, previously when i had to override for a single method i implemented this here: https://github.com/StackStorm-Exchange/stackstorm-slack/blob/master/bin/generate_openapi.py#L19

Would be probably good to add a "global" override or something here: https://github.com/StackStorm-Exchange/stackstorm-slack/blob/master/bin/generate_openapi.py#L156

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will take a look at that, thanks!

Copy link
Collaborator Author

@namachieli namachieli Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a simple loop and a constant, removed the previous change to ./bin/template.jinja
Regenerated actions and now token['required'] is being overridden to false

GLOBAL_PARAM_OVERRIDES = {

for p_override_key, p_override_value in six.iteritems(GLOBAL_PARAM_OVERRIDES):

Does this approach it more how you were seeing it?

…lity fixes, add CODEOWNERS, add unit testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants