Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mistral register re-run on failure #105

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Fix mistral register re-run on failure #105

merged 1 commit into from
Jan 31, 2017

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Jan 30, 2017 •
edited
Loading

Partially fixes #103 (comment)

If mistral-db-manage failed first time, - it's skipped on next playbok re-run. This is wrong behavior.

This caused by blocking conditions in when:, - they are removed now.

@arm4b arm4b added the bug label Jan 30, 2017
@arm4b arm4b added the RFR label Jan 30, 2017
@humblearner
Copy link
Contributor

when was to make the task: https://github.com/StackStorm/ansible-st2/pull/105/files#diff-6411b73900eb950467182a77f5e8f74aR73 idempotent. If it is still idempotent, 👍.

bigmstone
bigmstone approved these changes Jan 31, 2017
View reviewed changes
Copy link
Contributor

@bigmstone bigmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arm4b arm4b merged commit a6b0064 into master Jan 31, 2017
@arm4b arm4b deleted the fix/register-mistral-re-run branch January 31, 2017 17:19
@arm4b arm4b mentioned this pull request Jan 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigmstone bigmstone bigmstone approved these changes

@dzimine dzimine Awaiting requested review from dzimine

@Mierdin Mierdin Awaiting requested review from Mierdin

@humblearner humblearner Awaiting requested review from humblearner

Assignees
No one assigned
Labels
bug RFR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Register mistral actions" fails on staging-unstable.
3 participants
@arm4b @humblearner @bigmstone