Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install gpg before calling apt_key #305

Merged
merged 5 commits into from
Dec 29, 2021

Conversation

mamercad
Copy link
Contributor

Fixes #304 (at least the first problem).

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Dec 23, 2021
@mamercad
Copy link
Contributor Author

These two changes get me through the installation (on Focal, at least):

PLAY RECAP ******************************************************************************************************************
stackstorm                 : ok=86   changed=0    unreachable=0    failed=0    skipped=63   rescued=0    ignored=1

@mamercad
Copy link
Contributor Author

I don't see how these changes could cause the failures that I'm seeing in the integration tests... I'll dig deeper when I get a chance.

@mamercad
Copy link
Contributor Author

Hrm, I was able to vagrant up ubuntu18 and vagrant up ubuntu20 without issue, probably going to need some help understanding why the integrations tests are failing.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 👍

Everything looks good, just left one minor comment.

The failure is irrelevant to your PR as it breaks on the chatops tests.
We recently switched the CI system and looks like the GH Actions is not passing some chatops secret used in tests to the forked builds. We'll try to fix that in another PR.

roles/StackStorm.mongodb/tasks/mongodb_debian.yml Outdated Show resolved Hide resolved
Co-authored-by: Eugen Cusmaunsa <github@armab.io>
@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines. Very easy to review. and removed size/XS PR that changes 0-9 lines. Quick fix/merge. labels Dec 26, 2021
@mamercad
Copy link
Contributor Author

Thanks for the PR! 👍

Everything looks good, just left one minor comment.

The failure is irrelevant to your PR as it breaks on the chatops tests. We recently switched the CI system and looks like the GH Actions is not passing some chatops secret used in tests to the forked builds. We'll try to fix that in another PR.

Sweet, thanks for the help; I was surely confused since things were working locally (with Vagrant).

@arm4b arm4b merged commit 46c29e5 into StackStorm:master Dec 29, 2021
@mamercad mamercad deleted the mamercad/issue-304 branch December 30, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails on Ubuntu Focal 20.04.3
2 participants