Allow Erlang version on EL8 to be pinned, and by default use < 25 #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
cognifloyd
reviewed
May 19, 2022
| @@ -5,3 +5,5 @@ rabbitmq_plugins: [] | |||
| # - rabbitmq_management | |||
| # Set to "present" to install latest version, or specify specific version | |||
| rabbitmq_version: "present" | |||
| # Use version or wildcard | |||
| erlang_el8_version: "24*" | |||
There was a problem hiding this comment.
Suggested change
| erlang_el8_version: "24*" | |
| erlang_version: "24*" |
It's not el8 specific, right?
There was a problem hiding this comment.
It's not el8 specific, right?
Only EL8 failed last night. Looking at the packagecloud rabbit repo. EL8 has 25*, 24*, 23*. EL7 only has 23*.
So problem is EL8 specific at moment, and likely to not update EL7 as they never updated it for 24.
But you are right I at least need to do something as the file changed affects EL7 and EL8, but I'll have to have default versions for the two :-(
There was a problem hiding this comment.
In that case, you can add an extra when condition on the task that only uses the pinned version for el8
cognifloyd
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install on EL8 started to fail on RabbitMQ install. Problems reported "please re-compile this module with an Erlang/OTP 25 compiler"
Erlang 25 has been pushed to the RabbitMQ erlang repository, but according to https://www.rabbitmq.com/which-erlang.html erlang 25 support is preview.
Update so that erlang version can be specified, and make the default value 24* so do not pick up 25.
Partially resolves: #311