-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use version of erlang < 1.25 and fix EL8 passlib #313
Conversation
…rather than the sliced erlang packages
Seems to be a problem with dependencies. I have been unable to install erlang and rabbitMQ compatible verisons on U20 using the repositories we currently use (LaunchPad ones). Also affects U18.
So either:
Also the older erlang repositories seem to be available at their cloudsmith repos:
|
Using cloudsmith repos instead of LaunchPad allows us to install erlang version that works with rabbitmq |
- name: auth | Install pip pre-reqs (RedHat) | ||
become: yes | ||
pip: | ||
name: passlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we install the passlib
via pip for all the OS flavors to get rid of this kind of mishmash?
ansible-st2/roles/StackStorm.st2/vars/debian.yml
Lines 1 to 3 in 02b5ffb
# List of python variables | |
--- | |
passlib: python-passlib |
ansible-st2/roles/StackStorm.st2/vars/redhat_8.yml
Lines 1 to 3 in 02b5ffb
# List of python3 variables | |
--- | |
passlib: python3-passlib |
ansible-st2/roles/StackStorm.st2/vars/redhat.yml
Lines 1 to 3 in 02b5ffb
# List of python2 variables | |
--- | |
passlib: python-passlib |
ansible-st2/roles/StackStorm.st2/vars/debian_20.yml
Lines 1 to 3 in 02b5ffb
# List of python3 variables | |
--- | |
passlib: python3-passlib |
Wondering if it'll make it any better or if we'll hit another corner case with the environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll still need to mess about a bit, as the pip executable differs. So we have to point to pip3 on EL8, but we'll need to point to different pip versions on some of the other installs. (I tried with just the default pip module and no executable name - but that failed :-( )
So we'll just be replacing the passlib variable with a pip variable.
But might make it a little tidier. I'll give it a quick run on focal and EL8....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the efforts!
Approved the PR. Feel free to merge it with the fixes you'll find tidier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@armab We don't install default pip at moment for U20 as part of ansible install. So we'd need to add that in as well.
I'm not sure its going to make it any cleaner, just mean we'll have another pip on the box to perhaps get confused with....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way looks like a rake.
Alright, thanks for checking.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! 👍
Use the CloudSmith rabbitmq-erlang packages rather than the LaunchPad erlang packages for Debian installations, so that we can specify a 24.x version of the rabbitmq-erlang. (25.x and 22.x are only available in LaunchPad for Debian and fail with latest rabbitMQ).
We no-longer want to use the latest 1.25 that is available in the rabbitmq-erlang repository, as this means that rabbitmq fails to install, and instead reports error:
Resolves #312