Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Use Ansible Molecule for end-to-end testing (Rework) #329

Merged
merged 12 commits into from
Jan 5, 2023
Merged

CI: Use Ansible Molecule for end-to-end testing (Rework) #329

merged 12 commits into from
Jan 5, 2023

Conversation

mamercad
Copy link
Contributor

@mamercad mamercad commented Dec 31, 2022 •
edited

Relates to #328.

@pull-request-size pull-request-size bot added the size/XL PR that changes 500-999 lines. Consider splitting work into several ones that easier to review. label Dec 31, 2022
@mamercad mamercad mentioned this pull request Dec 31, 2022
Closed
@mamercad mamercad marked this pull request as ready for review December 31, 2022 15:40
arm4b
arm4b suggested changes Jan 2, 2023
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!
Running a dedicated CI job per OS distro should be much better.

Let's continue working on this approach 👍

.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
arm4b
arm4b suggested changes Jan 4, 2023
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just left a couple more minor comments before merging.

.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mamercad mamercad requested a review from arm4b January 5, 2023 13:02
arm4b
arm4b approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the changes 👍

@arm4b arm4b merged commit 222ee03 into StackStorm:master Jan 5, 2023
@mamercad
Copy link
Contributor Author

mamercad commented Jan 6, 2023

Looks good! Thanks for the changes 👍

Sweet, no problem!

@mamercad mamercad deleted the ansible-molecule-4 branch January 6, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

Assignees
No one assigned
Labels
enhancement maintenance refactor size/XL PR that changes 500-999 lines. Consider splitting work into several ones that easier to review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mamercad @arm4b