Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vars and input that references app context #104

Merged
merged 1 commit into from Nov 13, 2018
Merged

Fix vars and input that references app context #104

merged 1 commit into from Nov 13, 2018

Conversation

@m4dcoder
Copy link
Collaborator

@m4dcoder m4dcoder commented Nov 10, 2018

Fix the construction sequence of the workflow initial context. Assign the app context as the initial context before the workflow input and vars are rendered. This allows expressions in vars and input to reference variables set in the app context.

Fix the construction sequence of the workflow initial context. Assign the app context as the initial context before the workflow input and vars are rendered. This allows expressions in vars and input to reference variables set in the app context.
@m4dcoder m4dcoder requested a review from blag Nov 10, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 10, 2018

Codecov Report

Merging #104 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   94.24%   94.24%   +<.01%     
==========================================
  Files          38       38              
  Lines        2379     2381       +2     
  Branches      470      470              
==========================================
+ Hits         2242     2244       +2     
  Misses         79       79              
  Partials       58       58
Impacted Files Coverage Δ
orquesta/specs/native/v1/models.py 97.63% <100%> (ø) ⬆️
orquesta/conducting.py 91.98% <100%> (+0.03%) ⬆️
orquesta/specs/mistral/v2/workflows.py 83.01% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24c2c7...b76a252. Read the comment docs.

@blag
blag approved these changes Nov 10, 2018
Copy link
Contributor

@blag blag left a comment

LGTM

@m4dcoder m4dcoder merged commit 3028c15 into master Nov 13, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@m4dcoder m4dcoder deleted the fix-app-ctx branch Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants