staged-item-marked-completed #221
Conversation
New status for failed task item with incomplete tasks should be running
There was a problem hiding this comment.
There's not enough context in this PR to understand what you are trying to achieve. Please provide detail example with workflow definition, expected behavior, and actual behavior in the description here. Also, there are many unit tests that are not passing which means this conflicts with other use cases.
|
I have raised an issue against it #222 with detail and example workflow. Will check the test cases. |
|
@eg-lom This issue is related to StackStorm/st2#5054 and there's an open discussion there on how to handle the situation and not break existing use/test cases. The current design of the workflow engine, by intention, is to fail fast. This means that if there is any failure in action execution (either for a task, or item for a task), the workflow engine will halt the workflow execution and terminate. Making changes to the status from FAILED to RUNNING is going to break a lot of test cases here plus the downstream test cases in https://github.com/StackStorm/st2. Please describe your use case in the linked issue here and make sure the community agrees with the design before hacking the changes here. Otherwise, we run the risk of many iteration of back and forth review and rework. Thanks. |
New status for failed task item with incomplete tasks should be running