Add test model test_rule_with_secret_parameter_masked

StackStorm · Oct 9, 2019 · 7cfb390 · 7cfb390
1 parent 519fded
commit 7cfb390
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/st2api/tests/unit/controllers/v1/test_rule_views.py b/st2api/tests/unit/controllers/v1/test_rule_views.py
@@ -90,13 +90,11 @@ def test_get_all_parameters_mask_with_include_parameters(self):
         resp = self.app.get('/api/v1/rules?include_attributes=action')
         self.assertEqual(resp.status_int, http_client.OK)
         self.assertEqual(len(resp.json), 3)
-        pass
 
     def test_get_all_parameters_mask_with_exclude_parameters(self):
         resp = self.app.get('/api/v1/rules?exclude_attributes=action')
         self.assertEqual(resp.status_int, http_client.OK)
         self.assertEqual(len(resp.json), 3)
-        pass
 
     def _insert_mock_models(self):
         rule_ids = [rule['id'] for rule in self.rules.values()]

diff --git a/st2common/tests/unit/test_db.py b/st2common/tests/unit/test_db.py
@@ -441,6 +441,17 @@ def test_trigger_lookup(self):
                              'Incorrect trigger returned.')
         ReactorModelTestCase._delete([saved, triggertype])
 
+    def test_rule_with_secret_parameter_masked(self):
+        triggertype = ReactorModelTestCase._create_save_triggertype()
+        trigger = ReactorModelTestCase._create_save_trigger(triggertype)
+        runnertype = ActionModelTestCase._create_save_runnertype()
+        action = ActionModelTestCase._create_save_action(runnertype)
+        saved = ReactorModelTestCase._create_save_rule(trigger, action, False)
+        masked = RuleDB._mask_secrets(saved.action.)
+
+        for value in masked['parameters']['p4'].values():
+            self.assertEqual(value, MASKED_ATTRIBUTE_VALUE)
+
     @staticmethod
     def _create_save_triggertype():
         created = TriggerTypeDB(pack='dummy_pack_1', name='triggertype-1', description='',
@@ -666,7 +677,8 @@ def _create_save_action(runnertype, metadata=False):
             created.parameters = {
                 'p1': {'type': 'string', 'required': True},
                 'p2': {'type': 'number', 'default': 2868},
-                'p3': {'type': 'boolean', 'default': False}
+                'p3': {'type': 'boolean', 'default': False},
+                'p4': {'type': 'secret', 'default': "*****"}
             }
         return Action.add_or_update(created)