-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install MongoDB 3.4 by default #3592
Comments
With multiple DB versions we'll need I intentionally removed several Mongo Servers from the previous build matrix, which created an additional CI waiting queue for us. Saying that, I think the minimal solution is just to run Tests on latest Mongo version we currently support. It's also related to this bigger discussion: https://github.com/StackStorm/discussions/issues/245 |
Yeah, I agree, this should do for now. I will switch CI to 3.4 first and once the time comes for v2.4.0 update docs and installer scripts. |
Reopened to make sure we catch all the required depdendencies related to this change:
Anything else I'm missing? |
As mention in the other issue, st2-docker already seems to be using 3.4 so we should be fine there - https://github.com/StackStorm/st2-docker/blob/master/docker-compose.yml#L29. As far as puppet and chef modules go - I don't think it makes much sense to touch that. We haven't touched it for quite a long time so it's already very out of date. We should either decide it to fully support it officially (we don't have resources to do that) or officially deprecate it and add big warning to the repo (and perhaps make it community supported). |
Both repos are still alive :) I'm not talking about "officially" supporting that (also what that really means?), but notifying contributors about the upcoming change would be nice. |
Thanks for the heads up @armab ! On the puppet side it should be fairly easy. I have put a switch in to change MongoDB version based on the requested StackStorm version, currently it's pinned at 3.2. I'll bump it to 3.4 for st2 v2.4.0+ |
Right now we install MongoDB 3.2 by default with the installer script, but for v2.4.0 release we should update the script and docs to install MongoDB 3.4 by default.
We used to have unit tests on Circle CI running with both, MongoDB 3.2 and 3.4 by default (and before that also on Travis CI) until the recent changes by @armab so things should work just fine. IIRC, some of the users already upgraded and are running 3.4.
In addition to that, we should also look into unit tests running with multiple MongoDB versions in the future (once we move to 3.4 and 3.6 is out).
TODO changes
The text was updated successfully, but these errors were encountered: