Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install MongoDB 3.4 by default #3592

Closed
7 tasks done
Kami opened this issue Jul 20, 2017 · 6 comments
Closed
7 tasks done

Install MongoDB 3.4 by default #3592

Kami opened this issue Jul 20, 2017 · 6 comments
Assignees
Milestone

Comments

@Kami
Copy link
Member

Kami commented Jul 20, 2017

Right now we install MongoDB 3.2 by default with the installer script, but for v2.4.0 release we should update the script and docs to install MongoDB 3.4 by default.

We used to have unit tests on Circle CI running with both, MongoDB 3.2 and 3.4 by default (and before that also on Travis CI) until the recent changes by @armab so things should work just fine. IIRC, some of the users already upgraded and are running 3.4.

In addition to that, we should also look into unit tests running with multiple MongoDB versions in the future (once we move to 3.4 and 3.6 is out).

TODO changes

@Kami Kami added this to the 2.4.0 milestone Jul 20, 2017
@Kami Kami self-assigned this Jul 20, 2017
@arm4b
Copy link
Member

arm4b commented Jul 20, 2017

unit tests running with multiple MongoDB versions in the future

With multiple DB versions we'll need 4 containers x N DBs in Travis or 6 containers x N DBs in Circle.
With 3.2, 3.4, 3.6 we need 12-18 containers to run those tests + add here packaging containers.
So it's not possible without changing the CI system to something self-hosted, because that means bringing $$$ to CircleCI or TravisCI or as it was before, wait hours for the build status.

I intentionally removed several Mongo Servers from the previous build matrix, which created an additional CI waiting queue for us.

Saying that, I think the minimal solution is just to run Tests on latest Mongo version we currently support.

It's also related to this bigger discussion: https://github.com/StackStorm/discussions/issues/245

@Kami
Copy link
Member Author

Kami commented Jul 20, 2017

@armab

Saying that, I think the minimal solution is just to run Tests on latest Mongo version we currently support.

Yeah, I agree, this should do for now. I will switch CI to 3.4 first and once the time comes for v2.4.0 update docs and installer scripts.

@arm4b
Copy link
Member

arm4b commented Aug 1, 2017

Reopened to make sure we catch all the required depdendencies related to this change:

Anything else I'm missing?

@Kami
Copy link
Member Author

Kami commented Aug 1, 2017

As mention in the other issue, st2-docker already seems to be using 3.4 so we should be fine there - https://github.com/StackStorm/st2-docker/blob/master/docker-compose.yml#L29.

As far as puppet and chef modules go - I don't think it makes much sense to touch that. We haven't touched it for quite a long time so it's already very out of date. We should either decide it to fully support it officially (we don't have resources to do that) or officially deprecate it and add big warning to the repo (and perhaps make it community supported).

@arm4b
Copy link
Member

arm4b commented Aug 1, 2017

Both repos are still alive :)
I know for sure that chef-stackstorm works, puppet-st2 has some contributors now too (cc @nmaludy)

I'm not talking about "officially" supporting that (also what that really means?), but notifying contributors about the upcoming change would be nice.

@nmaludy
Copy link
Member

nmaludy commented Aug 1, 2017

Thanks for the heads up @armab !

On the puppet side it should be fairly easy. I have put a switch in to change MongoDB version based on the requested StackStorm version, currently it's pinned at 3.2. I'll bump it to 3.4 for st2 v2.4.0+

@arm4b arm4b closed this as completed Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants