Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis build script #1726

Merged
merged 1 commit into from Jul 17, 2015
Merged

Fix Travis build script #1726

merged 1 commit into from Jul 17, 2015

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Jul 16, 2015

Exit immediately if any command in scripts/travis.sh exits with a non-zero status.

My fail with recent changes, see:
https://travis-ci.org/StackStorm/st2/jobs/71310549#L156

@arm4b
Copy link
Member Author

arm4b commented Jul 16, 2015

Also @lakshmi-kannan coveralls fails when coverage decreased (-0.01%).

Seems increasing threshold in Coveralls settings just a bit should help: lemurheavy/coveralls-public#565 (comment)

@lakshmi-kannan
Copy link
Contributor

Changed decrease threshold to 2%

@lakshmi-kannan
Copy link
Contributor

@armab Can you add a dummy commit so we can validate?

Exit immediately if any command exits with a non-zero status
@arm4b arm4b added the RFR label Jul 17, 2015
@arm4b
Copy link
Member Author

arm4b commented Jul 17, 2015

I'll merge, since it's hotfix ♨️

arm4b pushed a commit that referenced this pull request Jul 17, 2015
@arm4b arm4b merged commit 528af1b into StackStorm:master Jul 17, 2015
@arm4b arm4b deleted the fix-travis-build branch July 17, 2015 13:14
@cognifloyd cognifloyd removed the RFR label Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants