Append_url parameter in ack messages #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emedvedev
added a commit
that referenced
this pull request
Dec 1, 2015
Append_url parameter in ack messages
| @@ -516,7 +516,8 @@ class ActionAliasAPI(BaseAPI, APIUIDMixin): | |||
| "type": "object", | |||
| "properties": { | |||
| "enabled": {"type": "boolean"}, | |||
| "format": {"type": "string"} | |||
| "format": {"type": "string"}, | |||
| "append_url": {"type": "boolean"} | |||
There was a problem hiding this comment.
Yes, same as enabled. We discussed it with @jfryman: URL is appended by default to everything (even a custom format string) unless explicitly set to "false".
There was a problem hiding this comment.
K. Then call out default value in the schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed this with @jfryman yesterday: StackStorm execution details URL will be appended to the end of the ack message by default unless specifically disabled with
append_url: false.