Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 binding support for the dev script #2897

Merged
merged 2 commits into from Sep 13, 2016
Merged

IPv6 binding support for the dev script #2897

merged 2 commits into from Sep 13, 2016

Conversation

tonybaloney
Copy link
Contributor

No description provided.

@estee-tew
Copy link

@bigmstone
Copy link
Contributor

I wonder. Should we listen on v6 and v4 by default? Having it be a binary option v4 or v6 feels weird. They're not usually mutually exclusive (in production).

@tonybaloney
Copy link
Contributor Author

I tried that. Gunicorn broke. 

Get Outlook for iOS

On Tue, Sep 13, 2016 at 11:02 AM +1000, "Matthew Stone" notifications@github.com wrote:

I wonder. Should we listen on v6 and v4 by default? Having it be a binary option v4 or v6 feels weird. They're not usually mutually exclusive (in production).


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@bigmstone
Copy link
Contributor

Did you try this?
http://docs.gunicorn.org/en/stable/settings.html#server-socket
Specifically: gunicorn -b 127.0.0.1:8000 -b [::1]:8000 test:app
Also, I do realize this is for a dev script and thus not all that important but would be good to know it works or breaks in dev.

@tonybaloney
Copy link
Contributor Author

In production, all of the service bindings get proxies through NGINX anyway, so having local IPv6 bindings wouldn't make much difference (unless I guess for those people addressing the API locally). I figured I was in the minority wanting proper IPv6 bindings on any host address (not localhost) so that's why I didn't make it default. 
There was a thread on gunicorn about multiple bindings, some systems consider [::] to mean any host, 4 or 6, some don't. 

Get Outlook for iOS

On Tue, Sep 13, 2016 at 11:11 AM +1000, "Matthew Stone" notifications@github.com wrote:

Did you try this?

http://docs.gunicorn.org/en/stable/settings.html#server-socket

Specifically: gunicorn -b 127.0.0.1:8000 -b [::1]:8000 test:app

Also, I do realize this is for a dev script and thus not all that important but would be good to know it works or breaks in dev.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@tonybaloney
Copy link
Contributor Author

this is the article, its system dependent, so yuck. benoitc/gunicorn#1138

@bigmstone
Copy link
Contributor

Yeah that's nasty. Also looks like the v6 addr will make it listen on both addresses on the platforms we support.

This seems to be the best way to approach it for now.

@bigmstone
Copy link
Contributor

I'm +1 on the change. Will let someone else put eyes on it and merge.

@emedvedev
Copy link
Contributor

emedvedev commented Sep 13, 2016

+1. Shouldn't be a problem.

@emedvedev emedvedev merged commit 07d26d6 into StackStorm:master Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants