Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis caching #3728

Merged
merged 2 commits into from
Sep 8, 2017
Merged

Fix Travis caching #3728

merged 2 commits into from
Sep 8, 2017

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Sep 8, 2017

This should fix cases when travis caches pip installs from https://github.com/StackStorm/st2/blob/master/requirements.txt#L9 when the target master branch code was actually updated (happened in #3721).

Pull Request caches rely first on master branch: https://docs.travis-ci.com/user/caching/#Pull-request-builds-and-caches So we won't cache master branch anymore. It means first build for every PR comes with no cache.

There is also no way to invalidate the cache at the moment once the content is changed in remote git, except of pip upgrade or version change in pip package. See reports in pip:

Using --editable pip requirements will fix the issue, but it's not supported by dh-virtualenv: spotify/dh-virtualenv#134


I won't know if the fix actually worked or not before merging this into master and testing #3727 afterwards.

@arm4b arm4b added the bug label Sep 8, 2017
@arm4b arm4b merged commit 9177b5c into master Sep 8, 2017
@arm4b arm4b deleted the fix/travis-caching branch September 8, 2017 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants