Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user field to re_run method #4785

Merged
merged 4 commits into from Sep 11, 2019

Conversation

trstruth
Copy link
Member

@trstruth trstruth commented Sep 3, 2019

The executions re_run route in st2api allows for a user to be specified in the request body.
image
This PR extends the same functionality to st2client.

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Sep 3, 2019
@blag blag added the CLI label Sep 3, 2019
@blag
Copy link
Contributor

blag commented Sep 3, 2019

Thanks for the contribution!

Please update the failing unit tests and tweak this line to wrap so the lines are < 100 characters long to pacify our linter.

@arm4b
Copy link
Member

arm4b commented Sep 4, 2019

We'll need a CHANGELOG update for this fix as well.

@arm4b arm4b added the bug label Sep 4, 2019
@trstruth
Copy link
Member Author

trstruth commented Sep 4, 2019

Not sure what "Please set the milestone" is asking me to do

@trstruth trstruth force-pushed the trstruth/st2client-user-re-run branch from fd9f1f1 to d55e5b0 Compare September 4, 2019 22:51
@arm4b arm4b added this to the 3.2.0 milestone Sep 5, 2019
@arm4b
Copy link
Member

arm4b commented Sep 5, 2019

Assigning milestone aka planned st2 version to every PR would be responsibility of repository maintainers.
It will bring better visibility and help community to understand which feature/fix planned and eventually shipped in different versions.
This is now enforced by CI check.

cc @StackStorm/team

@arm4b arm4b added enhancement and removed bug labels Sep 11, 2019
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@arm4b arm4b merged commit 3cfc71d into StackStorm:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants