Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Python Logging API Change #4923

Merged
merged 10 commits into from Oct 5, 2020
Merged

Fixes Python Logging API Change #4923

merged 10 commits into from Oct 5, 2020

Conversation

Dahfizz9897
Copy link
Contributor

@Dahfizz9897 Dahfizz9897 commented Apr 27, 2020 •
edited by arm4b

The logging module added a stacklevel=1 kwarg in python3.8 to the findCaller() function
We need to do the same since we override that method.

Closes #4922

@Dahfizz9897
Fixes Python Logging API Change
8f0bea7 
The logging module added a stacklevel=1 kwarg in python3.8
We need to do the same since we override that method.
@CLAassistant
Copy link

CLAassistant commented Apr 27, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Apr 27, 2020
@Dahfizz9897
Copy link
Contributor Author

This fixes this issue: #4922

@arm4b arm4b added this to the 3.3.0 milestone Apr 27, 2020
@arm4b arm4b added this to In progress in Ubuntu 20.04 (Focal Fossa) Support via automation Apr 27, 2020
blag
blag previously requested changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the stacklevel parameter isn't actually used anywhere, it would probably be better to use **kwargs to capture it.

@Dahfizz9897
Copy link
Contributor Author

Updated, but I had to use *args, **kwargs as the only parameters because other places in the logging library already call this function with the stacklevel parameter without specifying its name, so it would still error without an *args. And the existing stack_info wasn't used.

@arm4b arm4b added the python3 label Apr 29, 2020
nmaludy
nmaludy suggested changes Sep 29, 2020
View reviewed changes
Copy link
Member

@nmaludy nmaludy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a CHANGELOG entry for this?

arm4b
arm4b reviewed Oct 2, 2020
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@nmaludy
Update CHANGELOG.rst
a70b835 
Co-authored-by: Eugen C. <github@armab.io>
@arm4b arm4b dismissed blag’s stale review October 2, 2020 14:59

Requested changes were addressed by the PR author

@nmaludy nmaludy merged commit 40fd844 into StackStorm:master Oct 5, 2020
Ubuntu 20.04 (Focal Fossa) Support automation moved this from In progress to Done Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b left review comments

@nmaludy nmaludy nmaludy approved these changes

@blag blag blag left review comments

Assignees
No one assigned
Labels
enhancement python3 size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
No open projects
Ubuntu 20.04 (Focal Fossa) Support
  
Done
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Logging API Breaks in Python 3.8
5 participants
@Dahfizz9897 @CLAassistant @blag @arm4b @nmaludy