Allows GitLab SSH URLs on pack actions #5050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
|
|
nmaludy
suggested changes
Oct 1, 2020
There was a problem hiding this comment.
@asthLucas Thanks a ton for the PR, this looks good!
Would you mind please adding an entry into CHANGELOG.rst ?
It also might help to add a PR to the https://github.com/StackStorm/st2docs repo so that others know that gitlab URLs can be used.
Thanks again!
lcsaa
changed the title
pull-request-size
bot
added
size/S
|
@nmaludy Thanks for the advice. I`ve updated the changelog and the documentation on st2docs. |
nmaludy
approved these changes
Oct 5, 2020
|
I'm going to make this a blocker for v3.4 to ensure that it makes it in. I'll be working on fixing the end-to-end tests and rerunning them today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only GitHub based URL could be used for downloading and installing packs. This PR allows GitLab SSH URLs.