-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ldap support as auth backend #5082
Conversation
This time CLA is happy, thanks for that! 👍 Let's work in this PR if any more changes needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passed. Merging.
Thanks for the contribution @hnanchahal! 👍
The new version will be available in 3.4dev
Docker images today/tomorrow after automatic scheduled build/deploy/promotion.
As a follow-up, can you please also update the documentation here? https://docs.stackstorm.com/authentication.html#ldap-enterprise-edition (Github source: https://github.com/StackStorm/st2docs/blob/master/docs/source/authentication.rst)
Reword the LDAP configuration section removing Enterprise mentions as LDAP is part of the ST2 OSS core now.
Integrate LDAP auth https://github.com/StackStorm/st2-auth-ldap into st2 core.