Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticket #5078 fix: Resolves issue where st2stream crashes with a max depth error when connecting to a mongodb via SSL #5091

Merged
merged 6 commits into from Nov 26, 2020
Merged

ticket #5078 fix: Resolves issue where st2stream crashes with a max depth error when connecting to a mongodb via SSL #5091

merged 6 commits into from Nov 26, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 24, 2020 •
edited by arm4b

Fixes #5078

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Nov 24, 2020
@CLAassistant
Copy link

CLAassistant commented Nov 24, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@ghost ghost mentioned this pull request Nov 24, 2020
Closed
arm4b
arm4b suggested changes Nov 24, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 👍

Can you please provide a Changelog for this fix so we'll be able to merge it?
Please also compose the PR Title/Description so it'll be more clear what this Pull Request does and why.

@arm4b arm4b added the bug label Nov 24, 2020
@arm4b arm4b added this to the 3.4.0 milestone Nov 24, 2020
@ghost ghost changed the title fix for ticket #5078 ticket #5078 fix: Resolves issue where st2stream crashes with a max depth error when connecting to a mongodb via SSL Nov 24, 2020
arm4b
arm4b suggested changes Nov 25, 2020
View reviewed changes
CHANGELOG.rst Outdated
@@ -22,6 +22,7 @@ Changed

Fixed
~~~~~~~~~
* Added monkey patch fix to st2stream to enable it to work with mongodb via SSL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the Changelog format including the PR number and type of the change if it's (bug fix) (enhancement), etc. See other examples below.
You're also welcome to include your Name or github Username as a contributor credit.

punkrokk
punkrokk suggested changes Nov 26, 2020
View reviewed changes
Copy link
Member

@punkrokk punkrokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good just needs change log syntax updated.

CHANGELOG.rst Outdated
@@ -22,6 +22,7 @@ Changed

Fixed
~~~~~~~~~
* Added monkey patch fix to st2stream to enable it to work with mongodb via SSL. #5078 #5091
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the (bug fix) part here to be consistent.

arm4b
arm4b approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍
Merging.

@arm4b arm4b merged commit aa040bf into StackStorm:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

St2Stream service broken when using SSL with mongodb
3 participants
@CLAassistant @punkrokk @arm4b