Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode pack files as utf-8 instead of ascii #5106

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Conversation

blag
Copy link
Contributor

@blag blag commented Dec 16, 2020

This PR fixes the current issue plaguing the end-to-end tests on Ubuntu 16 when the bootstrap script attempts to install the stackstorm-st2 pack from StackStorm Exchange:

20201216T075024+0000 For the \"st2\" pack, the following content will be registered:
20201216T075024+0000 
20201216T075024+0000 actions   |  24
20201216T075024+0000 rules     |  0
20201216T075024+0000 sensors   |  0
20201216T075024+0000 aliases   |  12
20201216T075024+0000 triggers  |  0
20201216T075024+0000 
20201216T075024+0000 Installation may take a while for packs with many items.
20201216T075024+0000 
20201216T075025+0000 \t[ \u001b[93mscheduled\u001b[0m ] init_task
\t[  \u001b[93mrunning\u001b[0m  ] init_task
\t[ \u001b[92msucceeded\u001b[0m ] init_task
20201216T075027+0000 \t[ \u001b[93mscheduled\u001b[0m ] download_pack
\t[  \u001b[93mrunning\u001b[0m  ] download_pack
\t[ \u001b[92msucceeded\u001b[0m ] download_pack
20201216T075027+0000 \t[ \u001b[93mscheduled\u001b[0m ] make_a_prerun
\t[  \u001b[93mrunning\u001b[0m  ] make_a_prerun
\t[ \u001b[92msucceeded\u001b[0m ] make_a_prerun
20201216T075028+0000 \t[ \u001b[93mscheduled\u001b[0m ] get_pack_dependencies
\t[  \u001b[93mrunning\u001b[0m  ] get_pack_dependencies
\t[ \u001b[92msucceeded\u001b[0m ] get_pack_dependencies
20201216T075029+0000 \t[ \u001b[93mscheduled\u001b[0m ] check_dependency_and_conflict_list
\t[  \u001b[93mrunning\u001b[0m  ] check_dependency_and_conflict_list
\t[ \u001b[92msucceeded\u001b[0m ] check_dependency_and_conflict_list
20201216T075034+0000 \t[ \u001b[93mscheduled\u001b[0m ] install_pack_requirements
\t[  \u001b[93mrunning\u001b[0m  ] install_pack_requirements
\t[ \u001b[92msucceeded\u001b[0m ] install_pack_requirements
20201216T075035+0000 \t[ \u001b[93mscheduled\u001b[0m ] get_pack_warnings
\t[  \u001b[93mrunning\u001b[0m  ] get_pack_warnings
\t[ \u001b[92msucceeded\u001b[0m ] get_pack_warnings
20201216T075036+0000 \t[ \u001b[93mscheduled\u001b[0m ] register_pack
\t[  \u001b[93mrunning\u001b[0m  ] register_pack
\t[  \u001b[91mfailed\u001b[0m   ] register_pack
20201216T075036+0000 
20201216T075037+0000 \u001b[94mid\u001b[0m: 5fd9bc3f1431f79d4902d0e8
20201216T075037+0000 \u001b[94maction.ref\u001b[0m: packs.install
20201216T075037+0000 \u001b[94mparameters\u001b[0m: 
20201216T075037+0000   packs:
20201216T075037+0000   - st2
20201216T075037+0000   python3: false
20201216T075037+0000 \u001b[94mstatus\u001b[0m: \u001b[91mfailed\u001b[0m
20201216T075037+0000 \u001b[94mstart_timestamp\u001b[0m: Wed, 16 Dec 2020 07:50:23 UTC
20201216T075037+0000 \u001b[94mend_timestamp\u001b[0m: Wed, 16 Dec 2020 07:50:36 UTC
20201216T075037+0000 \u001b[94mresult\u001b[0m: 
20201216T075037+0000   errors:
20201216T075037+0000   - message: Execution failed. See result for details.
20201216T075037+0000     result:
20201216T075037+0000       exit_code: 1
20201216T075037+0000       result: None
20201216T075037+0000       stderr: \"st2.actions.python.St2RegisterAction: DEBUG    Calling client method \"register\" with kwargs \"{'types': ['all'], 'packs': ['st2']}\"
20201216T075037+0000 Traceback (most recent call last):
20201216T075037+0000   File \"/opt/stackstorm/st2/lib/python3.6/site-packages/python_runner/python_action_wrapper.py\", line 334, in <module>
20201216T075037+0000     obj.run()
20201216T075037+0000   File \"/opt/stackstorm/st2/lib/python3.6/site-packages/python_runner/python_action_wrapper.py\", line 193, in run
20201216T075037+0000     output = action.run(**self._parameters)
20201216T075037+0000   File \"/opt/stackstorm/packs/packs/actions/pack_mgmt/register.py\", line 82, in run
20201216T075037+0000     format_func=format_result)
20201216T075037+0000   File \"/opt/stackstorm/packs/packs/actions/pack_mgmt/register.py\", line 150, in _run_client_method
20201216T075037+0000     result = method(**method_kwargs)
20201216T075037+0000   File \"/opt/stackstorm/st2/lib/python3.6/site-packages/st2client/models/core.py\", line 42, in decorate
20201216T075037+0000     return func(*args, **kwargs)
20201216T075037+0000   File \"/opt/stackstorm/st2/lib/python3.6/site-packages/st2client/models/core.py\", line 564, in register
20201216T075037+0000     self.handle_error(response)
20201216T075037+0000   File \"/opt/stackstorm/st2/lib/python3.6/site-packages/st2client/models/core.py\", line 168, in handle_error
20201216T075037+0000     response.raise_for_status()
20201216T075037+0000   File \"/opt/stackstorm/st2/lib/python3.6/site-packages/requests/models.py\", line 941, in raise_for_status
20201216T075037+0000     raise HTTPError(http_error_msg, response=self)
20201216T075037+0000 requests.exceptions.HTTPError: 400 Client Error: Bad Request
20201216T075037+0000 MESSAGE: Failed to register alias \"/opt/stackstorm/packs/st2/aliases/actions_list.yaml\" from pack \"st2\": 'ascii' codec can't decode byte 0xe2 in position 439: ordinal not in range(128) for url: http://127.0.0.1:9101/v1/packs/register
20201216T075037+0000 \"
20201216T075037+0000       stdout: ''
20201216T075037+0000     task_id: register_pack
20201216T075037+0000     type: error
20201216T075037+0000   output:
20201216T075037+0000     conflict_list: []"

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Dec 16, 2020
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Good catch!

@blag blag added this to the 3.4.0 milestone Dec 16, 2020
@blag blag merged commit 0898b49 into master Dec 16, 2020
@blag blag deleted the decode-files-as-utf8 branch December 16, 2020 18:08
@arm4b arm4b added this to In progress in StackStorm v3.4.0 via automation Dec 16, 2020
@arm4b arm4b moved this from In progress to Done in StackStorm v3.4.0 Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API bug packs python3 regression size/XS PR that changes 0-9 lines. Quick fix/merge.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants