bug fix for output_value[output_key] is not iterable

[guzzijones]

if output_value[output_key] is not iterable and instead a boolean I receive the following error code from the st2api.
IE:

output_value: {'stdout': '', 'stderr': '', 'exit_code': 0, 'result': True}
spec: {'status': 'bool'}
key: output
output_key: result

ERROR:

ERROR: 500 Server Error: Internal Server Error
MESSAGE: Internal Server Error for url: https://stackstorm-vf.ifp.lmco.com/api/executions/60f94708c3a6d1a338dc0ad7/children/?depth=-1

[cognifloyd]

This would probably also apply to int, float, and other types that are not Collections.

[guzzijones]

Works for me.

…

On Thu, Jul 22, 2021, 11:28 AM Jacob Floyd ***@***.***> wrote: This would probably also apply to int, float, and other types that are not Collections. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5309 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACZ5TIL6BJQOVDERVX6Y6W3TZA2KJANCNFSM5AZ62MYA> .

[m4dcoder]

Can you add a unit test that reproduce this issue so we know this patch is going to fix?

[cognifloyd]

Hmm. So there were two issues: 1) the bug you found. 2) your spec is not well formed.

Instead of this spec:

status: bool

You need this jsonschema spec:

status:
  type: bool

I'm looking at how to adjust the tests now.

[cognifloyd]

K. I added #5319 based on this.
It turns out that output_schema_validation is actually quite limited.
Your output has to be an object and all properties in that object have to be objects as well. Then, you can use secret masking.
I left a FIXME comment about adjusting the schema to allow output_schema to describe more kinds of output (and then allow secret masking on those additional types as well).

[CLAassistant]

All committers have signed the CLA.

[guzzijones]

Where did we leave this?

[cognifloyd]

I have too many irons in the fire. I can't work on this for now. I'll come back to it when I can shift focus.

[guzzijones]

@guzzijones add changelog entry.

[cognifloyd]

OK. I added a changelog entry that mentions that output_schema handling will change in a future release.
I also adjusted bailing out early if the output value is not an object or if a spec in output_schema is mal-formed.

I think this is ready to merge.

[m4dcoder]

Conditional approve. The proper fix will be followed up in v3.7.

[cognifloyd]

Yes. I will rework/expand #5319 before 3.7.0.