Implementation of RBAC for KeyValuePair #5354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
m4dcoder
requested changes
Sep 13, 2021
pull-request-size
bot
added
size/L
m4dcoder
requested changes
Sep 24, 2021
Clean up and simplify the put method of the key value pair API. Remove logic from the code that is redundant or no longer applies.
Clean up and simplify the delete method of the key value pair API. Remove logic from the code that is redundant or no longer applies.
m4dcoder
force-pushed
the
rbac_keyvaluepair
branch
from
2f410a6
to
77632eb
Compare
Refactor get_all_system_kvp_names_for_user to ensure there's no leakage of non key value pair resource type or resource uid of user scoped key value pair.
Refactor RBAC unit tests for the key value API to ensure get_all is working properly for different scopes and for admin/non-admin users.
|
Moving this feature to v3.7.0 to give more time for folks to soak this in. |
m4dcoder
approved these changes
Oct 3, 2021
m4dcoder
requested changes
Oct 3, 2021
m4dcoder
requested changes
Oct 4, 2021
m4dcoder
approved these changes
Dec 9, 2021
|
@ashwini-orchestral The PR needs a Changelog. Please add one. @m4dcoder Additionally, do we need documentation changes for this new feature as well? |
|
@armab Corresponding PR for docs at StackStorm/st2docs#1092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented RBAC functionality and unit tests for key-value pairs for existing and new permission types. Previously, RBAC feature for key value pairs are not yet implemented.
RBAC is enabled in the st2.conf file. Access to a key value pair is checked in the KeyValuePair API controller.
This change requires RBAC backend support @ PR StackStorm/st2-rbac-backend#55.