Minor updates for Rocky and upgrade docker engine for CI #5552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
16 tasks
cognifloyd
approved these changes
Jan 24, 2022
rush-skills
reviewed
Jan 26, 2022
contrib/linux/actions/service.py
Outdated
| @@ -70,6 +70,7 @@ def get_linux_distribution(): | |||
| re.search(distro, "Redhat") | |||
| or re.search(distro, "Fedora") | |||
| or re.search(distro, "CentOS Linux") | |||
There was a problem hiding this comment.
Not exactly related to this PR, but can we modify this to say CentOS instead of CentOS Linux? The stream releases won't match the current version, since platform.linux_distribution() for stream returns
platform.linux_distribution()
>> ('CentOS Stream', '8', '')
and the lsb_release way returns
→ lsb_release -i -s
CentOSStream
On CentOS 7, I guess this will still fail as well with Python >= 3.8
→ lsb_release -i -s
CentOS
There was a problem hiding this comment.
I would be happy with that. Could you file a new PR?
pull-request-size
bot
added
size/S
auto-merge was automatically disabled
January 28, 2022 10:09
Pull Request is not mergeable
arm4b
reviewed
Jan 28, 2022
Co-authored-by: Eugen Cusmaunsa <stackstorm@armab.io>
amanda11
changed the title
arm4b
reviewed
Jan 28, 2022
cognifloyd
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of StackStorm/community#88