Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pylint (via pantsbuild) #5837

Merged
merged 11 commits into from
Dec 11, 2022
2 changes: 1 addition & 1 deletion .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ on:
jobs:
# Lint checks which don't depend on any service containes, etc. to be running.
lint-checks:
name: 'Lint Checks (pants runs: shellcheck, bandit, black, flake8)'
name: 'Lint Checks (pants runs: shellcheck, bandit, black, flake8, pylint)'
runs-on: ubuntu-20.04

env:
Expand Down
3 changes: 2 additions & 1 deletion BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,6 @@ python_requirements(
)

python_test_utils(
name="test_utils0",
name="test_utils",
skip_pylint=True,
)
2 changes: 1 addition & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Added
* Continue introducing `pants <https://www.pantsbuild.org/docs>`_ to improve DX (Developer Experience)
working on StackStorm, improve our security posture, and improve CI reliability thanks in part
to pants' use of PEX lockfiles. This is not a user-facing addition.
#5778 #5789 #5817 #5795 #5830 #5833 #5834 #5841 #5840 #5838 #5842
#5778 #5789 #5817 #5795 #5830 #5833 #5834 #5841 #5840 #5838 #5842 #5837
Contributed by @cognifloyd


Expand Down
4 changes: 3 additions & 1 deletion contrib/chatops/tests/BUILD
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
python_tests()
python_tests(
skip_pylint=True,
)
1 change: 1 addition & 0 deletions contrib/core/tests/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
python_tests(
skip_pylint=True,
overrides={
"test_action_sendmail.py": {
"dependencies": [
Expand Down
4 changes: 3 additions & 1 deletion contrib/examples/tests/BUILD
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
python_tests()
python_tests(
skip_pylint=True,
)
4 changes: 3 additions & 1 deletion contrib/linux/tests/BUILD
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
python_tests()
python_tests(
skip_pylint=True,
)
1 change: 1 addition & 0 deletions contrib/packs/tests/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
python_tests(
skip_pylint=True,
overrides={
"test_action_download.py": {
"dependencies": [
Expand Down
5 changes: 5 additions & 0 deletions contrib/runners/action_chain_runner/tests/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
__defaults__(
all=dict(
skip_pylint=True,
)
)
5 changes: 5 additions & 0 deletions contrib/runners/announcement_runner/tests/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
__defaults__(
all=dict(
skip_pylint=True,
)
)
5 changes: 5 additions & 0 deletions contrib/runners/http_runner/tests/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
__defaults__(
all=dict(
skip_pylint=True,
)
)
5 changes: 5 additions & 0 deletions contrib/runners/inquirer_runner/tests/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
__defaults__(
all=dict(
skip_pylint=True,
)
)
5 changes: 5 additions & 0 deletions contrib/runners/local_runner/tests/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
__defaults__(
all=dict(
skip_pylint=True,
)
)
5 changes: 5 additions & 0 deletions contrib/runners/noop_runner/tests/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
__defaults__(
all=dict(
skip_pylint=True,
)
)
5 changes: 5 additions & 0 deletions contrib/runners/orquesta_runner/tests/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
__defaults__(
all=dict(
skip_pylint=True,
)
)
5 changes: 5 additions & 0 deletions contrib/runners/python_runner/tests/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
__defaults__(
all=dict(
skip_pylint=True,
)
)
5 changes: 5 additions & 0 deletions contrib/runners/remote_runner/tests/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
__defaults__(
all=dict(
skip_pylint=True,
)
)
5 changes: 5 additions & 0 deletions contrib/runners/winrm_runner/tests/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
__defaults__(
all=dict(
skip_pylint=True,
)
)