Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate lockfile for using twine #5841

Merged
merged 3 commits into from Dec 8, 2022
Merged

Generate lockfile for using twine #5841

merged 3 commits into from Dec 8, 2022

Conversation

cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Dec 7, 2022

Background

This is another part of introducing pants, as discussed in various TSC meetings.

Related PRs can be found in:

Overview of this PR

This configures pants and generates a lockfile so it can use twine when running the publish goal to publish wheels to pypi.

We will still need more config before we can use pants to just build wheels, let alone publish them. But, this is the last lockfile I know of that we need. Getting this in now reduces the diff with my PoC branch so it is easier to plan the next PRs.

Here is the pants.toml config this PR adds:

st2/pants.toml

Lines 150 to 152 in 2eb18db

[twine]
lockfile = "lockfiles/twine.lock"
version = "twine>=3.7.1,<3.8"

twine version

I copied the pants' default version for twine: https://www.pantsbuild.org/v2.14/docs/reference-twine#version

lockfiles/twine.lock

This lockfile differs from the one that comes with pants because we have different python interpreter constraints.

@cognifloyd cognifloyd added this to the pants milestone Dec 7, 2022
@cognifloyd cognifloyd self-assigned this Dec 7, 2022
@pull-request-size pull-request-size bot added the size/XXL PR that changes 1000+ lines. You should absolutely split your PR into several. label Dec 7, 2022
Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cognifloyd cognifloyd enabled auto-merge (squash) December 8, 2022 15:40
@cognifloyd cognifloyd merged commit 1fc3bd0 into master Dec 8, 2022
@cognifloyd cognifloyd deleted the pants-twine branch December 8, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependency pantsbuild size/XXL PR that changes 1000+ lines. You should absolutely split your PR into several. st2-packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants