Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standardize format of BUILD overrides #5948

Merged
merged 2 commits into from Mar 31, 2023

Conversation

cognifloyd
Copy link
Member

Quick/minor reformat of some BUILD files.

I like to use dict() under overrides so that syntax highlighting looks similar to a regular target.

So, use this

python_sources(
    overrides={
        "foobar.py": dict(
            dependencies=[...],
        ),
    },
)

instead of this

python_sources(
    overrides={
        "foobar.py": {
            "dependencies": [...],
        },
    },
)

@cognifloyd cognifloyd added this to the pants milestone Mar 31, 2023
@cognifloyd cognifloyd self-assigned this Mar 31, 2023
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Mar 31, 2023
@cognifloyd cognifloyd merged commit f35c1a6 into master Mar 31, 2023
25 checks passed
@cognifloyd cognifloyd deleted the standardize-overrides-syntax branch March 31, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pantsbuild refactor size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants