-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Kubernetes docs to cover changes to our Helm Chart #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cognifloyd
commented
Sep 9, 2021
- k8s_ha: Refactor intro paragraph and drop helm 2 reference
- k8s_ha: Refactor configurable values list
- k8s_ha: Reword a few sections for clarity.
- k8s_ha: Copy notes about deploying mongo/rabbitmq from chart readme
- k8s_ha: begin documenting st2packs vs volumes methods
- k8s_ha: reword description of using Shared Volumes
- k8s_ha: add more notes about Storage Volumes
- Note packs.volumes vs packs.images - Add more settings to the list of configurable values. - List auto-generated secrets and update the secrets warning.
Also fix the channel. We use #k8s for the helm chart, not #docker.
ericreeves
reviewed
Sep 9, 2021
ericreeves
reviewed
Sep 9, 2021
arm4b
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
v0.70.0 of the helm chart was just released: https://github.com/StackStorm/stackstorm-ha/releases/tag/v0.70.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.