Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inquiry Documentation #595

Merged
merged 19 commits into from
Oct 6, 2017
Merged

Inquiry Documentation #595

merged 19 commits into from
Oct 6, 2017

Conversation

Mierdin
Copy link
Member

@Mierdin Mierdin commented Aug 30, 2017

This PR provides all documentation for the new Inquiry feature introduced in StackStorm/st2#3653

Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Also fixed typo

Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
.. code-block:: bash

~$ st2 inquiry respond 59ab26af32ed35752062d2dc
Should we continue? (boolean): 123
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behavior is not what I see

(virtualenv)vagrant@st2dev /m/s/s/st2 ❯❯❯ st2 inquiry respond 59ca9c86d9d7ed1559489a20                                                                                                       api-ask-response ✭ ◼
usage: st2 inquiry respond [-h] [-t TOKEN] [--api-key API_KEY] [-j] [-y]
                           id response
st2 inquiry respond: error: too few arguments
(virtualenv)vagrant@st2dev /m/s/s/st2 ❯❯❯

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per slack, this behavior changed in a recent commit, so using an updated branch should better reflect this portion of the docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore me. I was testing with an older version.

Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
@Mierdin Mierdin changed the title [WIP] Inquiry Documentation Inquiry Documentation Oct 6, 2017
@Mierdin Mierdin added the RFR label Oct 6, 2017
@warrenvw warrenvw self-requested a review October 6, 2017 17:38
Copy link
Contributor

@warrenvw warrenvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. But second pair of 👀 & approval would be good to have.

@Mierdin Mierdin merged commit f351ede into master Oct 6, 2017
@LindsayHill LindsayHill deleted the inquiry-docs branch September 6, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants