Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jammy and CentOS Stream 9 #111

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Conversation

mamercad
Copy link
Contributor

@mamercad mamercad commented Oct 7, 2023

Added build_one.sh helper script as well for building a single target.

They built for me locally:

❯ docker images | grep packagingbuild | grep -E 'stream|jammy' | awk '{print $1" "$2}'
stackstorm/packagingbuild centosstream9
stackstorm/packagingbuild jammy

@arm4b
Copy link
Member

arm4b commented Oct 7, 2023

Thanks for the first steps!

I've added jammy and centosstream9 to the Docker Hub CI settings, so hopefully we'll see the builds on a new commits in this PR.

@arm4b arm4b added the OS support Support/issues/PRs on a specific OS label Oct 7, 2023
@mamercad
Copy link
Contributor Author

mamercad commented Oct 7, 2023

Thanks for the first steps!

I've added jammy and centosstream9 to the Docker Hub CI settings, so hopefully we'll see the builds on a new commits in this PR.

No problem - feels like we may need to add/update Docker CI things?

@mamercad
Copy link
Contributor Author

mamercad commented Oct 7, 2023

Thanks for the first steps!
I've added jammy and centosstream9 to the Docker Hub CI settings, so hopefully we'll see the builds on a new commits in this PR.

No problem - feels like we may need to add/update Docker CI things?

Ah, we should do #110; I'll probably take a crack at it $soon.

@arm4b
Copy link
Member

arm4b commented Oct 7, 2023

Closed #110 as Docker Hub builds are working again as I see them in GH status checks.

feels like we may need to add/update Docker CI things?

Yeah, just updated it. You may still need to push new commits for the new tags to build for this PR.

@mamercad
Copy link
Contributor Author

mamercad commented Oct 8, 2023

Closed #110 as Docker Hub builds are working again as I see them in GH status checks.

feels like we may need to add/update Docker CI things?

Yeah, just updated it. You may still need to push new commits for the new tags to build for this PR.

Cool, I see centosstream9 and jammy passing now.

@mamercad
Copy link
Contributor Author

mamercad commented Oct 8, 2023

Closed #110 as Docker Hub builds are working again as I see them in GH status checks.

feels like we may need to add/update Docker CI things?

Yeah, just updated it. You may still need to push new commits for the new tags to build for this PR.

Cool, I see centosstream9 and jammy passing now.

As usual, I'm participating in Hacktoberfest, do you mind adding the hacktoberfest-accepted label to this pull request please?

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@arm4b arm4b merged commit 5c94fc7 into StackStorm:master Oct 9, 2023
7 of 11 checks passed
@mamercad mamercad deleted the jammy-and-centos9 branch October 9, 2023 12:17
@nzlosh nzlosh added this to the 3.9.0 milestone Jan 30, 2024
@nzlosh nzlosh linked an issue Jan 31, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted OS support Support/issues/PRs on a specific OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ubuntu 22.04 support
3 participants