Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task delay model #858

Merged
merged 8 commits into from
Mar 30, 2021
Merged

Conversation

shital-orchestral
Copy link
Contributor

Added Delay Property as a new field under task properties, with the use of field, we can add delay in-between execution of the tasks. Thanks

@m4dcoder m4dcoder added this to the 3.5.0 milestone Feb 17, 2021
Copy link
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shital-orchestral

  1. The value of the task delay can be an expression (string) or an integer. Here is an example where the delay is an expression at https://github.com/StackStorm/st2/blob/master/contrib/examples/actions/workflows/orquesta-delay.yaml#L17. This current PR doesn't load this workflow definition and display the delay value correctly.
  2. Is it possible to provide a hint when hover over the delay field which type of values user can input? For example, when hover over delay, hint that user can input an expression or integer.

Copy link
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shital-orchestral Can you make the delay input box the same as the delay in the task retry model? This will be more consistent.

@amanda11
Copy link
Contributor

amanda11 commented Mar 5, 2021

LGTM @m4dcoder @shital-orchestral
The only feature I saw from testing was that I can enter -1 for delay, and the UI accepts this. But then when the workflow runs I get an error stating:
TypeError: The value of task delay is not type of integer.",

But I think this problem extends to other places as well, and its difficult to verify in the UI as we support strings for putting in contexts. So I think this is ok.

@amanda11 amanda11 added the bug label Mar 5, 2021
@amanda11 amanda11 added this to In progress in StackStorm v3.5.0 via automation Mar 5, 2021
@amanda11 amanda11 added enhancement and removed bug labels Mar 5, 2021
@amanda11
Copy link
Contributor

I don't seem to get a red box up when I'm in the field and enter -3 for delay.
I get one when I have the field as empty, but when it's a negative number then I don't see any message.

@amanda11
Copy link
Contributor

LGTM - I can see the negative number check now. Not sure if I had the wrong artificact before - but looks good.

@m4dcoder
Copy link
Contributor

@amanda11 Here you go. You should be seeing the error shown in the screenshot.

Screen Shot 2021-03-29 at 12 52 04 PM

Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants