-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task delay model #858
Task delay model #858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The value of the task delay can be an expression (string) or an integer. Here is an example where the delay is an expression at https://github.com/StackStorm/st2/blob/master/contrib/examples/actions/workflows/orquesta-delay.yaml#L17. This current PR doesn't load this workflow definition and display the delay value correctly.
- Is it possible to provide a hint when hover over the
delay
field which type of values user can input? For example, when hover overdelay
, hint that user can input an expression or integer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shital-orchestral Can you make the delay input box the same as the delay in the task retry model? This will be more consistent.
LGTM @m4dcoder @shital-orchestral But I think this problem extends to other places as well, and its difficult to verify in the UI as we support strings for putting in contexts. So I think this is ok. |
I don't seem to get a red box up when I'm in the field and enter -3 for delay. |
LGTM - I can see the negative number check now. Not sure if I had the wrong artificact before - but looks good. |
@amanda11 Here you go. You should be seeing the error shown in the screenshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added Delay Property as a new field under task properties, with the use of field, we can add delay in-between execution of the tasks. Thanks