Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingressClassName field missing #336

Closed
ciechonp opened this issue Dec 12, 2022 · 2 comments · Fixed by #340
Closed

ingressClassName field missing #336

ciechonp opened this issue Dec 12, 2022 · 2 comments · Fixed by #340
Labels
enhancement New feature or request

Comments

@ciechonp
Copy link

As of Kubernetes 1.18 ingressClassName field was added. kubernetes.io/ingress.class is now deprecated.
https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotation
Can Ingress definition in this chart be updated to include ingressClassName field?
@arm4b arm4b added the enhancement New feature or request label Dec 12, 2022
@arm4b
Copy link
Member

arm4b commented Dec 12, 2022

Thanks for the report 👍
A PR contribution would be helpful to support this.

@arm4b
Copy link
Member

arm4b commented Dec 12, 2022

somewhat related to #331

@mamercad mamercad mentioned this issue Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for providing ingressClassName mamercad/stackstorm-k8s
2 participants
@arm4b @ciechonp